Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
RichText: own undo signalling #10650
This is a proposal for the
It's not always clear when the
How has this been tested?
Test undoing and redoing changes from
Types of changes
TinyMCE's logic for undo levels, for reference:
@aduth @mcsf This branch now has the undo timeout consistently, but I cannot figure out what exactly the problem is. I can also reproduce it locally in headless mode, but as soon as I turn headless off, it does not occur at all, even at slowo=0. It seems there's only one extra undo level being created, if I undo once more in the test it passes. I've not been able to figure it out further.
Yeah that's true. We want to create undo levels as soon as typing is interrupted. Here listening for mousedown instead will probably suffice.
3 times, most recently
Nov 2, 2018
referenced this pull request
Nov 5, 2018
It should behave roughly the same as before. With this change we can also fine tune it ourselves. Ideas for other triggers are welcome. Not sure what else we can do, maybe a typing pause could trigger an undo level? I don't think we can rely on punctuation as that's not universal.