Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account citation when transform a quote to paragraph #10685

Merged
merged 4 commits into from Oct 17, 2018
Merged

Take into account citation when transform a quote to paragraph #10685

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef43797
Take into account citation when transform a quote to paragraph
oandregal Oct 17, 2018
39f0ebd
Refactor to take into account blank quote or cite
oandregal Oct 17, 2018
96fa317
Protect against void quote and cite
oandregal Oct 17, 2018
e4a7300
Update e2e tests
oandregal Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-library/src/quote/index.js
View file
Open in desktop
Expand Up @@ -97,8 +97,8 @@ export const settings = {
{
type: 'block',
blocks: [ 'core/paragraph' ],
transform: ( { value } ) =>
split( create( { html: value, multilineTag: 'p' } ), '\u2028' )
transform: ( { value, citation } ) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be added after split, no? No need to parse it.

split( create( { html: value + `<p>${ citation }</p>`, multilineTag: 'p' } ), '\u2028' )
.map( ( piece ) =>
createBlock( 'core/paragraph', {
content: toHTMLString( piece ),
Expand Down