New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has-dates class to Latest Posts block if applicable #10727

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@swissspidy
Member

swissspidy commented Oct 18, 2018

Description

This changes the Latest Posts block to add a has-dates class when the Display post date option is set. The class is added both in the editor and on the front end.

How has this been tested?

Tested this using the local Docker environment by adding a Latest Posts block and toggling that option.

Screenshots

Editor:

screenshot 2018-10-18 at 12 11 35

Front end:

screenshot 2018-10-18 at 12 11 44

Types of changes

This adds a new has-dates class, as is already the case with the "Latest Comments" block.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

Fixes #10691.

@ocean90

This would make it consistent with the Latest Comments block.

@danielbachhuber danielbachhuber added this to the 4.2 milestone Oct 23, 2018

@danielbachhuber danielbachhuber merged commit 75acaa1 into master Oct 23, 2018

2 checks passed

codecov/project 49.5% remains the same compared to 73ce8fd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the update/10691-latest-posts-has-dates branch Oct 23, 2018

antpb added a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment