New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speak: Add/complete audible feedback for link editing #10795

Merged
merged 2 commits into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@adamsilverstein
Contributor

adamsilverstein commented Oct 19, 2018

Description

When users complete an action adding, editing or removing a link announce those action completions to assistive screen readers.

Fixes #1867

How has this been tested?

Adding and removing links in chrome with mac voice over enabled - the actions were properly announced.

Types of changes

  • Speak ‘link removed’ when a link is removed
  • Speak ‘link edited’ when a link is edited

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@adamsilverstein adamsilverstein requested a review from afercia Oct 19, 2018

@adamsilverstein adamsilverstein force-pushed the feature/speak-link-actions branch from 94f692a to 2a9fb0c Oct 19, 2018

@adamsilverstein adamsilverstein requested a review from mtias Oct 19, 2018

@adamsilverstein adamsilverstein added this to the 4.2 milestone Oct 22, 2018

@tofumatt

Nice, thanks!

@tofumatt tofumatt merged commit fa895eb into master Oct 23, 2018

2 checks passed

codecov/project 49.25% (-0.02%) compared to 48c1209
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tofumatt tofumatt deleted the feature/speak-link-actions branch Oct 23, 2018

@iseulde

This comment has been minimized.

Member

iseulde commented Oct 24, 2018

No tests? :(

@tofumatt

This comment has been minimized.

Member

tofumatt commented Oct 24, 2018

My bad 😓, I've filed: #11006 and assigned it to me!

antpb added a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018

Speak: Add/complete audible feedback for link editing (WordPress#10795)
* Speak ‘link removed’ when a link is removed

* Speak ‘link edited’ when a link is edited
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment