Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve post locking modal #10886
There are few issues with post locking modal introduced in #4217. This PR tries to fix them and make it look more like post locking modal in classic editor screen (see function
Current post type
There are two changes here: "All Posts" and "View all posts" texts were changed to use current post type label, and URL of those links now links to the screen of current post type. Both of these changes already exist in post locking modal in classic editor screen.
Explanation that "post" is generic and may be of any type is removed. There are two reasons for this: there are other strings using "post" in this modal that don't have such comment and they shouldn't have it because those strings can be used elsewhere (they would need context instead of comment), and this is how it's done in post locking modal in classic editor screen.
Link to "All Posts" screen was changed to button for consistency with both other case and usage in post locking modal in classic editor screen.
Added translator comments for strings with placeholder, added dot at the end of two sentences that didn't have it, and used apostrophe instead of single-quote character as per guidelines.
referenced this pull request
Nov 10, 2018
@dimadin thank you for the contribution here. overall this looks good, I am not certain about the translator comments - your explanation makes sense.
As I said in #11710, only few strings use single quote. Unfortunately, GlotPress search doesn't work with
Other languages wouldn’t even use those words.
Tested this out locally and looks good. One potential issue using the full post type label for the button is that for longer post type names, the current fixed width design may lead to some button overflow that doesn't look great.
Somewhat of an edge case, this is probably something we can fix by adjusting the CSS in a subsequent PR.