New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Show resizer on "Media & Text" block on unified toolbar mode #10913

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Oct 22, 2018

Description

Fixes: #10895
On unified toolbar mode it was not possible to resize the media on Media & Text block.
During the elaboration of #9416 this bug was addressed but I think during subsequent rebases and changes more concretely the usage of our abstracted Resizable box we had a regression.

This PR applies exactly the same fix that was applied in spacer block to the Media & Text block.

How has this been tested?

I checked it is possible to resize the media in Media & Text block in all mode including the unified toolbar.

@jorgefilipecosta jorgefilipecosta requested a review from Soean Oct 22, 2018

@jorgefilipecosta jorgefilipecosta added this to the 4.1 - UI freeze milestone Oct 22, 2018

@jorgefilipecosta jorgefilipecosta changed the title from Fix: Show resizer onMedia & Text block on unified toolbar mode. to Fix: Show resizer on Media & Text block on unified toolbar mode. Oct 22, 2018

@jorgefilipecosta jorgefilipecosta changed the title from Fix: Show resizer on Media & Text block on unified toolbar mode. to Fix: Show resizer on "Media & Text" block on unified toolbar mode Oct 22, 2018

@Soean

Soean approved these changes Oct 22, 2018

Bug is fixed. Now I am able to resize the image.

@jorgefilipecosta jorgefilipecosta merged commit 74214c0 into master Oct 23, 2018

2 checks passed

codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/media-and-text-resizer-unified-toolbar branch Oct 23, 2018

youknowriad added a commit that referenced this pull request Oct 24, 2018

Fix: Show resizer on "Media & Text" block on unified toolbar mode (#1…
…0913)

## Description
Fixes: #10895
On unified toolbar mode, it was not possible to resize the media on Media & Text block.
During the elaboration of #9416 this bug was addressed but I think during subsequent rebases and changes more concretely the usage of our abstracted Resizable box we had a regression.

This PR applies exactly the same fix that was applied in spacer block to the Media & Text block.


## How has this been tested?
I checked it is possible to resize the media in Media & Text block in all modes including the unified toolbar.

antpb added a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018

Fix: Show resizer on "Media & Text" block on unified toolbar mode (Wo…
…rdPress#10913)

## Description
Fixes: WordPress#10895
On unified toolbar mode, it was not possible to resize the media on Media & Text block.
During the elaboration of WordPress#9416 this bug was addressed but I think during subsequent rebases and changes more concretely the usage of our abstracted Resizable box we had a regression.

This PR applies exactly the same fix that was applied in spacer block to the Media & Text block.


## How has this been tested?
I checked it is possible to resize the media in Media & Text block in all modes including the unified toolbar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment