Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Sidebar: Avoid focus loss on active tab change #10917
Partially addresses: #8079
This pull request seeks to resolve an issue of focus loss when changing active sidebar tabs for the editor settings sidebar ("Document", "Block").
Update: It has been implemented with 72569ab.
Focus loss occurs because each specific sidebar renders the entirety of the
The bug occurs because React is unable to reconcile the two element trees, and is therefore forced to unmount and remount an entirely new sidebar wrapper.
An initial attempt here was to invert rendering, having each specific sidebar populating only the
Verify that no focus loss occurs when changing tabs in the sidebar.
Ensure end-to-end tests pass:
referenced this pull request
Oct 23, 2018
Locally I'm getting a failure on:
> ● splitting and merging blocks › should remove at most one paragraph in forward direction
Sorry, I thought I clicked "submit review" hours ago but I guess not, I'm just the worst on this PR
From the looks the snapshot is wrong so something is off here and needs fixing.