New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text: Add field that allows changing image alt text from the sidebar #11073

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Oct 25, 2018

This PR adds a field that allows changing the alt of the selected image on Media & Text block from the sidebar.

Fixes: #10924

How has this been tested?

I checked that I can correctly change the alt text of the image from the sidebar.
I checked that when a video is selected the alt text input field does not appear.

Screenshots

image

@jorgefilipecosta jorgefilipecosta self-assigned this Oct 25, 2018

@jorgefilipecosta jorgefilipecosta requested a review from Soean Oct 25, 2018

@Soean

Soean approved these changes Oct 25, 2018

Thanks, the code looks fine and the alt text works in backend and frontend
👍

@StaggerLeee

This comment has been minimized.

StaggerLeee commented Oct 25, 2018

It should have full wide option. Many themes do this and if you plan to turn Gutenberg to visual theme editor this option is necessary.

@jorgefilipecosta jorgefilipecosta merged commit 506f4ee into master Oct 26, 2018

2 checks passed

codecov/project 48.88% (-0.01%) compared to 4317761
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the add/alt-picker-media-text branch Oct 26, 2018

@jorgefilipecosta jorgefilipecosta added this to the 4.2 milestone Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment