Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore displaying formatting shortcuts in toolbar #11104

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@ellatrix
Copy link
Member

commented Oct 26, 2018

Description

After #10209, shortcuts no longer display in the tooltips of the formatting toolbar. This branch adds extra props on ToolbarButton to display the wanted combination (there can be more than one, e.g. link).

How has this been tested?

Check the formatting buttons' tooltips.

Screenshots

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ellatrix ellatrix added this to the 4.2 milestone Oct 26, 2018

@ellatrix ellatrix requested review from gziolo and WordPress/gutenberg-core Oct 26, 2018

@gziolo

gziolo approved these changes Oct 26, 2018

Copy link
Member

left a comment

Code looks good. I haven't tested.

@ellatrix ellatrix merged commit 0a1d6e0 into master Oct 26, 2018

2 checks passed

codecov/project 48.4% (-0.01%) compared to 506f4ee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ellatrix ellatrix deleted the fix/display-shortcuts branch Oct 26, 2018

@mtias mtias added the Regression label Oct 30, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.