Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Try: Make gallery keyboardable #11205
The intent of this PR is to fix #3836, but for now this is just the barebones initial work.
I would like your thoughts on the best approach to take before I optimize too far in one direction. As such, this PR does the bare minimum to get tabbing working for the gallery, and then we can go from there. For example, this PR simply adds a
Your thoughts are most welcome.
Just tested this locally and it's much better for keyboard accessibility, though it should be noted the actual labelling of these elements for screen readers is still quite bad. See:
It might be good to have an
aria-label or something on images with no alt attributes… but even then it might be nice to preface it with
"image 2 of 3: $alt"
That's fine for a future issue though; this issue is about keyboard accessibility and this is way better than
I tried testing
@designsimply Odd, it worked for me when I checked it out. From master, to test this you should try:
git checkout master git pull origin master git branch -D try/keyboardable-gallery git fetch origin git checkout -b try/keyboardable-gallery origin/try/keyboardable-gallery
That should definitely cover it