New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste: Google Docs: fix nested formatting, sub, sup and del #11207

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@iseulde
Member

iseulde commented Oct 29, 2018

Description

Fixes #10946 (which I thought would be an easy fix after all).

Does two things:

  • Allows nested formatting from Google Docs (or similar structures). E.g. text that is both bolded and italicised.
  • Converts strikethrough, subscript, and superscript from Google Docs.

How has this been tested?

Tests have been added.

Screenshots

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@iseulde iseulde requested a review from WordPress/gutenberg-core Oct 29, 2018

@iseulde iseulde force-pushed the fix/google-docs-formatting branch from ccd04ce to 4e6df8f Nov 6, 2018

@iseulde iseulde added this to the 4.3 milestone Nov 6, 2018

@youknowriad

LGTM 👍

@iseulde

This comment has been minimized.

Member

iseulde commented Nov 8, 2018

Thanks!

@iseulde iseulde merged commit 27b1529 into master Nov 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iseulde iseulde deleted the fix/google-docs-formatting branch Nov 8, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment