New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostPublishPanel: constraint tabbing within panel #11403

Merged
merged 5 commits into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@nosolosw
Member

nosolosw commented Nov 2, 2018

Addresses part of #4187 (comment)

@nosolosw nosolosw self-assigned this Nov 2, 2018

@nosolosw nosolosw changed the title from Constrain tabbing to within the PostPublishPanel to PostPublishPanel: constraint tabbing Nov 2, 2018

@nosolosw nosolosw added this to the Merge: Accessibility milestone Nov 2, 2018

@nosolosw nosolosw requested a review from tofumatt Nov 2, 2018

@tofumatt

Makes sense to me; any chance we could get a quick E2E test here that ensures that tabbing doesn't move outside the panel? 😄

@tofumatt tofumatt modified the milestones: Merge: Accessibility, 4.3 Nov 2, 2018

@nosolosw

This comment has been minimized.

Member

nosolosw commented Nov 5, 2018

Not that I haven't tried! But I'm struggling to see what makes Puppeteer sad. In theory, tests should be as simple as this. In practice, they are failing.

The problem seems to be that focus stays and the title and doesn't change to the PostPublishPanel after it is opened - it works properly in Gutenberg across browsers. @tofumatt would you have any guess why that's failing in Puppeteer?

@nosolosw nosolosw changed the title from PostPublishPanel: constraint tabbing to PostPublishPanel: constraint tabbing within panel Nov 5, 2018

@nosolosw

This comment has been minimized.

Member

nosolosw commented Nov 5, 2018

Figured in 05f51f3: the post needs to have some content to be publishable.

@nosolosw nosolosw merged commit e7ec3b3 into master Nov 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nosolosw nosolosw deleted the update/publish-flow-accesibility branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment