Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make it possible to undo prefix transforms #11497
This PR adjusts the prefix transforms so that they only execute when they match text right at the caret, so that they are undoable, and makes the check faster checking if the previous character is a space and not using any regular expressions otherwise on the whole text. Also adds e2e tests for all prefix and enter transforms, and adds some documentation.
How has this been tested?
Extra e2e tests have been added, but ensure e.g. list shortcuts like
Types of changes
Yes, let’s merge the other undo PR first :)…
On Fri, 9 Nov 2018 at 13:06, Riad Benguella ***@***.***> wrote: Going to punt this for 4.4 as well. Tests are failing and this is just a way to divide work an ship. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11497 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEfg60JtWO87z9-iQNHX7MJ0lwGUMRfFks5utWG-gaJpZM4YOqvO> .
Nov 19, 2018
1 check passed
Haven't looked deeper, but probably some browsers, like Chrome, fail to visualise the trailing space. We might have to pad it with a non breaking space.