RNmobile: Trigger media library picker #11511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypest
added
the
Mobile App - i.e. Android or iOS
… value The caption field is optional so it is valid to have it undefined due to GB web.
pinarol
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Tested via WordPress-Android app
- Open a post
- Create image block
- Tap "Media Library"
- Pick an image from WP media library
- Verify that image block is updated with the selected image
- Set a caption for the image
- Repeat these steps multiple times to see if multiple image blocks can be added&updated
|
Thanks for adding a fix commit @pinarol ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wires up the "Media Library" button on the Image placeholder block and triggers the media picker of the parent native app over the Native<->RN bridge. It provides a callback to be called by the Native side to send the selected image URL back into RN.
How has this been tested?
Using this native mobile side PR: wordpress-mobile/gutenberg-mobile#220
Types of changes
Adds a call to a Native<->Bridge function.
Checklist: