Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix/issue 5693 firefox focus trap #11601
How has this been tested?
Browser this fix in tested in Chrome, Safari, Firefox, Windows Firefox
Types of changes
Interrupted the key event on inputURL if the caret position isn't at the beginning or end of the input field text to mimic the expected behavior in non-Win FF browsers
referenced this pull request
Nov 7, 2018
Thanks for the PR @timwright12! A few meta points around the PR:
- no need to reference this PR in the original issue; GitHub does that for us so it's just extra notifications/noise that isn't needed
- You can use "Fixes #xyz" in the issue description so the issue you're working on fixing will be closed automatically once the patch lands
- You should remove the addition of the
gutenberg-mobilesubmodule; that was removed awhile back and shouldn't be committed
Otherwise the process around everything looks good
This looks good but I think could use comments that clarify things a bit more; right now this code would be a bit confusing to a developer unaware of this bug or the reason for this code to exist.
Normally I'd also advocate for an E2E (end-to-end) test here, but our E2E tests run in Chromium on Linux so
Thanks for the patch, let me know if anything needs clarification, but I think after some comment tweaks this'll be good to merge!