New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify sidebar tabs aria-labels. #11618

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
3 participants
@afercia
Contributor

afercia commented Nov 8, 2018

Description

This PR seeks to improve the sidebar tabs aria-label attributes for better translations in other languages, so their accessibility is preserved also in languages other than English. For more details, please refer to the related issue #11617.

Fixes #11617

@afercia afercia requested a review from brandonpayton Nov 8, 2018

@nerrad

nerrad approved these changes Nov 22, 2018

Looks okay to me, assuming there's no freeze on translation strings this is good to go 👍

@gziolo gziolo added this to the 4.6 milestone Nov 22, 2018

@gziolo gziolo merged commit 6e8e1bc into master Nov 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/simplify-sidebar-tabs-aria-labels branch Nov 22, 2018

@gziolo

This comment has been minimized.

Member

gziolo commented Nov 22, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment