Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
This also required adding a :not(.no-js) to the fullscreen body class
How has this been tested?
Types of changes
referenced this pull request
Nov 9, 2018
Ideally the "learn more" is a link to instructions re: how to enable JS, but if we don't have that, just delete it.
I know this is now getting a bit more complex, but can we add some more conditions whether the Classic Editor plugin is already installed and whether it's active? Perhaps also whether the user has the capability to install it.
At least a direct link to the classic editor if the plugin is already active would be nice.
@swissspidy I know, so much effort on a rare edge case, but might as well do it properly.
I did consider that about if the plugin is installed, however the user should not get to this page since it is a Gutenberg page and if the plugin is installed they will go straight to the Classic Editor.
I also just had to push up some CSS z-index positioning stuff to make it clickable, no such thing as a quick fix.
Yeah. Might be behind a conditional:
In the first version, "Classic Editor" links to the current URL with an extra