Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Further improve columns block. #11659
This PR is a followup to thoughts in #11620 (comment).
It improves the columns block further by doing two things:
To elaborate on 1, in #11620 we used pointer-events to disable the individual column blocks as selectable using the mouse. This is because those columns are not actionable at the moment, and in the current implementation of the column, being able to hover and select them only causes issues with selecting the parent columns block, which is actionable.
However pointer events was not enough for the empty state of a columns block. In this state, the block features no inner blocks, except the individual column blocks, because no content has yet been inserted yet. In this state, you see the "appender", which is not actually a block even though it looks exactly the same as an empty paragraph. Because this is not technically a block, the deepest nested child is a column, which is then allowed to be hovered.
In 1 I add a workaround to that, to simply visually hide the hover effect. I expect this to be refactored in a future columns update, but for the time being it makes it far more usable.
To elaborate on 2, there has been a long time issue with the appender (again, not the block, the fake version that we use before an empty paragraph is inserted) wrapping text in translations. This is because text cannot wrap in an
This might affect themes which specify the input element for increased specificity in their editor styles, but overall it still seems like a worthwhile change to make, since it's the only way we can allow the writing prompt to wrap its text.
Nov 9, 2018
Might be something which could be fixed by using
Nov 9, 2018
1 check passed
Just so you know, nesting columns like this actually comes up surprisingly often in page building. At some point in phase 2 you should be able to do stuff like this without running into any weirdness.