Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Restore the block hover and focus styles in Unified Toolbar mode. #11737
The Unified Toolbar mode should not remove outlines. This was discussed and agreed by the accessibility team and it's our recommendation as a team.
For example, I may find Unified Toolbar mode useful for my workflow but, as a user with vision impairments, still want a clear indication of hover and focus on the blocks. Instead, I can't use Unified Toolbar because it removes focus indication.
Quoting from the related issue #10559
This PR is an effort to propose a positive action. It partially reverts #9394. An option for a lighter UI when writing is already available with "Spotlight Mode" and as a team we feel that's the proper place for UI modifications that are clearly extraneous to a "Unified Toolbar" option.
It just restores the default styles used in the default mode. Anyways, here's the screenshots:
focus before (caret is in the second block):
On hover there's a more visible blue border. I wonder why the hover style is more prominent than the focus style.
This is intentional because the really intense hover style on focus is a bit distracting.
I am for this change because it makes things consistent, and something like spotlight mode should be what does away with/controls these hover/focus states, not the toolbar positioning.
I also see the benefit in some kind of higher-contrast option that enables more intense focus colours, but I think that should be separate.
cc'ing some others for their feedback because while I like this, I don't think I have final design say