Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Link popover: prevent mouse event propagation #11753
In a link popover if you press the mouse button down and then drag it triggers a selection event in the block list under the popover, which then results in the popover disappearing.
This is demonstrated here:
This PR prevents the mouse down event from propagating, so stopping the twitchy popover.
How has this been tested?
Tested through the included new e2e test.
I think we did similar propagation stopping outside modals under the premise they're a sort of independent document? It's not flagrantly offensive to me on glance, though I'd wish we could do so in a way which was wholesale, not picking individual events to which the behavior should apply.