New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with unclickable block warnings #11768

Merged
merged 2 commits into from Nov 13, 2018

Conversation

@jasmussen
Contributor

jasmussen commented Nov 12, 2018

Fixes #11764.

This PR makes the "Resolve" and "Convert to HTML" buttons clickable again.

screenshot 2018-11-12 at 17 20 01

Fix regression with unclickable block warnings
Fixes #11764.

This PR makes the "Resolve" and "Convert to HTML" buttons clickable again.

@jasmussen jasmussen added this to the 4.4 milestone Nov 12, 2018

@jasmussen jasmussen self-assigned this Nov 12, 2018

@jasmussen jasmussen requested review from johngodley and WordPress/gutenberg-core Nov 12, 2018

@tofumatt

Looks good, but it'd be ace to have a regression test for this one. I'll try to cook one up real quick.

@mkaz

This comment has been minimized.

Member

mkaz commented Nov 12, 2018

Tested and confirmed this fixes the issue of buttons not being clickable.

@tofumatt

This comment has been minimized.

Member

tofumatt commented Nov 13, 2018

FYI I couldn't cook up a test quickly for this, obviously. 😓

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Nov 13, 2018

FYI I couldn't cook up a test quickly for this, obviously. 😓

No worries, I think @johngodley might look at one separately, see #11764 (comment)

@jasmussen jasmussen merged commit 38001c6 into master Nov 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/block-warning branch Nov 13, 2018

johngodley added a commit that referenced this pull request Nov 13, 2018

Add e2e test for invalid blocks
Test that the invalid block warning appears and that buttons are clickable. Should cover the issue fixed in #11768

johngodley added a commit that referenced this pull request Nov 14, 2018

Add e2e test for invalid blocks (#11814)
Test that the invalid block warning appears and that buttons are clickable. Should cover the issue fixed in #11768

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Fix regression with unclickable block warnings (WordPress#11768)
* Fix regression with unclickable block warnings

Fixes WordPress#11764.

This PR makes the "Resolve" and "Convert to HTML" buttons clickable again.

* Add comments.

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Add e2e test for invalid blocks (WordPress#11814)
Test that the invalid block warning appears and that buttons are clickable. Should cover the issue fixed in WordPress#11768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment