Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove componentWillReceiveProps from ColorPicker #11772
We want to get rid of
This is the
Besides those updates, the
How this PR fixes it
We wanted the
Ugh, this has taken more time than I expected. The
I still need to update the tests I've added in this PR to the new changes, but wanted to give you as much time as possible for review.
referenced this pull request
Nov 14, 2018
Additional changes happened. Author requested a new review.
@jorgefilipecosta that was a good catch, thanks! :)
@jorgefilipecosta @mcsf @ryelle It took me a few days to get back to this, sorry about that. The bug was caused by an extra check (
jorgefilipecosta left a comment
In my tests, I did not found any regression so I think this PR is ready. Thank you @nosolosw for all the iterations performed. This is a nice step in removing deprecated react methods.
As noted during the discussions, we may have an opportunity to simplify the way these components work based on the prototype code shared.