New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies for @wordpress/components #11778

Merged
merged 2 commits into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@georgeh
Contributor

georgeh commented Nov 12, 2018

Description

Fixes #11017 and maybe woocommerce/wc-admin#616

How has this been tested?

Test project at https://github.com/georgeh/issue-11017

Confirmed that webpack cannot build @wordpress/components without @wordpress/rich-text.

Due to the way the packages are referenced, it may not be possible to test until this change is published. Gutenberg packages use relative paths, which makes it so that they cannot be installed via git branches.

@georgeh georgeh requested a review from youknowriad Nov 12, 2018

@youknowriad

This comment has been minimized.

Contributor

youknowriad commented Nov 13, 2018

Looks like you nede to run npm install to update the lock file.

@georgeh

This comment has been minimized.

Contributor

georgeh commented Nov 13, 2018

@youknowriad good catch, thanks. Added. LMK if you can think of any ways to test this branch in the test project before publishing.

@youknowriad

LGTM 👍 I'm fine shipping, if you really want to try before shipping, you can probably use npm link locally

@georgeh georgeh merged commit 8704fcc into master Nov 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@georgeh georgeh deleted the fix/components-package-dependencies branch Nov 14, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Fix dependencies for @wordpress/components (WordPress#11778)
* Add rich-text dependency for @wordpress/components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment