New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude HTML editing from Columns and Column blocks. #11785

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@mtias
Contributor

mtias commented Nov 13, 2018

Fixes #11438

Editing these wrapper blocks in HTML directly is fragile and prone to breaking the users' content. HTML editing should be left to leaf-blocks.

Exclude HTML editing from Columns and Column blocks.
Editing these wrapper blocks in HTML directly is fragile and prone
to breaking the users' content.

HTML editing should be left to leaf-blocks.

@mtias mtias added this to the 4.4 milestone Nov 13, 2018

@gziolo

gziolo approved these changes Nov 13, 2018

LGTM 👍

@gziolo

This comment has been minimized.

Member

gziolo commented Nov 13, 2018

It was super hard to select Column block :)

By the way, if you manage to select it, the icon for the block is mispositioned, cc @jorgefilipecosta @jasmussen :

screen shot 2018-11-13 at 11 05 45

@gziolo gziolo merged commit c206d07 into master Nov 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/exclude-html-editing-on-columns branch Nov 13, 2018

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Nov 13, 2018

It was super hard to select Column block :)

This is intentional because it is not very actionable right now. Next time set focus in the first block in a column, then press up arrow. Or just use the block traversal tool in the toolbar.

I will take a look at the misalignment.

@mtias

This comment has been minimized.

Contributor

mtias commented Nov 13, 2018

@gziolo easiest way to select the intermediary column is by using the block navigator in the header.

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Exclude HTML editing from Columns and Column blocks. (WordPress#11785)
Editing these wrapper blocks in HTML directly is fragile and prone
to breaking the users' content.

HTML editing should be left to leaf-blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment