New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop propagating to DOM elements the `focusOnMount` prop from `NavigableToolbar` components #11804

Merged
merged 4 commits into from Nov 15, 2018

Conversation

Projects
None yet
3 participants
@mmtr
Contributor

mmtr commented Nov 13, 2018

Description

This PR removes the focusOnMount from the props transferred to NavigableMenu when rendering a NavigableToolbar component.

Fixes #11769.

How has this been tested?

Locally by checking in the React devtools that the focusOnMount prop is not passed down to the children.

Screenshots

Before
screen shot 2018-11-12 at 17 43 24

After
screen shot 2018-11-12 at 17 46 43

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@mmtr mmtr self-assigned this Nov 13, 2018

@mmtr mmtr requested review from youknowriad and aduth Nov 13, 2018

@mmtr mmtr referenced this pull request Nov 13, 2018

Closed

Update wordpress monorepo #28427

@aduth aduth requested a review from jorgefilipecosta Nov 13, 2018

@jorgefilipecosta

LGTM 👍 Thank you for catching and fixing this bug.
I checked on React dev tools that the prop is not passed down.
I do not see the warning in the console; I'm trying to check why it does not appear in my environment.

@mmtr

This comment has been minimized.

Contributor

mmtr commented Nov 13, 2018

@jorgefilipecosta yeah, I don't see the warning when running locally Gutenberg. I think that the build process is suppressing the warning messages.

I can see it when using the package in another project like Calypso (Automattic/wp-calypso#28427 (comment)).

@mmtr mmtr merged commit 0604cd0 into master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mmtr mmtr deleted the fix/navigable-toolbar-focusonmount branch Nov 15, 2018

@youknowriad youknowriad added this to the 4.4 milestone Nov 15, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment