Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix escape key failing to close inline link popover #11806
Ensure the escape key can be used to close the Inline Link UI regardless of where focus is within the popover.
Unfortunately this is only bound to a subset of the popover's UI. If the focus was on the settings part of the popover, the escape key would not trigger closure of the popover.
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
referenced this pull request
Nov 13, 2018
It works correctly on my tests
There is only one small detail that can be improved in the future, but it is not a regression and not a blocker of this PR. If we are in the middle of a paragraph, we press meta +k and escape the cursor goes back to the start of a paragraph instead of staying in the middle.