New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better position sticky toolbar on floats #11810

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@jasmussen
Contributor

jasmussen commented Nov 13, 2018

The toolbar for floats, beyond the mobile breakpoint, was a little offset. This PR fixes it.

Before:

screenshot 2018-11-13 at 12 21 18

After:

screenshot 2018-11-13 at 12 21 05

Better position sticky toolbar on floats
The toolbar for floats, beyond the mobile breakpoint, was a little offset. This PR fixes it.

@jasmussen jasmussen added this to the 4.4 milestone Nov 13, 2018

@jasmussen jasmussen self-assigned this Nov 13, 2018

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Nov 13, 2018

@tofumatt

🚢 🚢 🚢

Looks good!

@mtias mtias merged commit d521f25 into master Nov 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtias mtias deleted the fix/floats-sticky-scrollbar branch Nov 13, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Better position sticky toolbar on floats (WordPress#11810)
The toolbar for floats, beyond the mobile breakpoint, was a little offset. This PR fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment