New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary className attribute. Fixes #11664 #11831

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
4 participants
@ninio
Copy link
Contributor

ninio commented Nov 13, 2018

Description

Added a check for empty string to the onChange handler of the "Additional CSS Class field".
If the string is empty the setAttributes is called with { className: undefined }
This will resolve #11664

How has this been tested?

Created a new post and added a heading block.
In the Advanced menu, added a class and switched to the Code Editor

Tested on local WP running on Windows with Chrome 70.0.3538.102

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@ajitbohra

This comment has been minimized.

Copy link
Member

ajitbohra commented Nov 21, 2018

PR includes commits from other PR's I guess only relevant change here is

https://github.com/WordPress/gutenberg/pull/11831/files#diff-8dbba509e48db673fbe1ad06dd51d289

@ninio

This comment has been minimized.

Copy link
Contributor Author

ninio commented Nov 21, 2018

I merged master in an attempt to solve the failing Travis builds

@jorgefilipecosta jorgefilipecosta force-pushed the ninio:fix/11664 branch from e0f4b16 to 6dbcf66 Jan 30, 2019

@jorgefilipecosta
Copy link
Member

jorgefilipecosta left a comment

I checked the relevant commit, picked it and applied a force push with it. The change makes sense to me and fixes the problem 👍 Thank you for your contribution!

@jorgefilipecosta jorgefilipecosta merged commit b09c855 into WordPress:master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

daniloercoli added a commit that referenced this pull request Jan 30, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg: (36 commits)
  Fixes plural messages POT generation. (#13577)
  Typo fix (#13595)
  REST API: Remove oEmbed proxy HTML filtering (#13575)
  Removed unnecessary className attribute. Fixes #11664 (#11831)
  Add changelog for RSS block (#13588)
  Components: Set type=button for TabPanel button elements. (#11944)
  Update util.js (#13582)
  Docs: Add accessbility specific page (#13169)
  Rnmobile/media methods refactor (#13554)
  chore(release): publish
  chore(release): publish
  Plugin: Deprecate gutenberg_get_script_polyfill (#13536)
  Block API: Parse entity only when valid character reference (#13512)
  RichText: List: fix indentation (#13563)
  Plugin: Deprecate window._wpLoadGutenbergEditor (#13547)
  Plugin: Avoid setting generic "Edit Post" title on load (#13552)
  Plugin: Populate demo content by default content filters (#13553)
  RichText: List: Fix getParentIndex (#13562)
  RichText: List: Fix outdent with children (#13559)
  Scripts: Remove npm run build from test-e2e default run (#13420)
  ...
@ninio

This comment has been minimized.

Copy link
Contributor Author

ninio commented Jan 31, 2019

Thanks for the merge! @jorgefilipecosta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment