New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getBlockName instead of getBlock in selectors #11841

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Nov 14, 2018

Extracted from #11811

This PR avoids using the slow getBlock selector in favor of just getBlockName when possible.

@youknowriad youknowriad added this to the 4.4 milestone Nov 14, 2018

@youknowriad youknowriad self-assigned this Nov 14, 2018

@youknowriad youknowriad requested a review from WordPress/gutenberg-core Nov 14, 2018

@youknowriad youknowriad force-pushed the update/selectors-use-get-block-name branch from 846f684 to ce11913 Nov 14, 2018

@aduth

aduth approved these changes Nov 14, 2018

@youknowriad youknowriad merged commit bea32a8 into master Nov 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/selectors-use-get-block-name branch Nov 14, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment