New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN mobile] pass isSelected to RichText components #11857

Merged
merged 5 commits into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@mzorz
Contributor

mzorz commented Nov 14, 2018

Description

This PR passes the isSelected prop down to the implementation of RichText components to make them respond to focus changes accordingly. This PR is tested in conjunction with wordpress-mobile/gutenberg-mobile#237

Screenshots

focus_insert2

Types of changes

New feature (non-breaking change which adds functionality)

To test:

  • Please follow instructions in related Mobile Gutenberg PR repo.
@daniloercoli

LGTM!

@mzorz mzorz merged commit db84d19 into master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mzorz mzorz deleted the rnmobile/is-selected-rich-text branch Nov 15, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

[RN mobile] pass isSelected to RichText components (WordPress#11857)
* adds prop isSelected on RCTAztecView in RichText, copying value from passed props

* adding isSelected prop to Heading block to handle focus in native

* adding isSelected prop to Paragraph block to handle focus in native

* fixed lint warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment