Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update: Keep ratio on cover video backgrounds #11886
This PR updates cover block to use object-fit cover instead of object-fit fill for the video background.
How has this been tested?
Verify the cover block still works as before.
changed the title from
Update: Keep ratio on cover video backgrounds.
Update: Keep ratio on cover video backgrounds
Nov 15, 2018
This works for me in my testing. I can confirm that the aspect ratio before was skewed, and it isn't anymore. The extra crop is fine.
I was concerned the added overflow rule would make the sticky toolbars not work — it has done so in the past. But the sticky toolbar works fine here, so the scope for the rule is good.