New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block selection when removing blocks #11898

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Nov 15, 2018

Extracted from #11811

This fixes a small typo/error where we were comparing a block Id to a block Object. I don't think it has a lot of impacts on the behavior though.

@youknowriad youknowriad added this to the 4.4 milestone Nov 15, 2018

@youknowriad youknowriad self-assigned this Nov 15, 2018

@youknowriad youknowriad requested a review from WordPress/gutenberg-core Nov 15, 2018

@youknowriad youknowriad modified the milestones: 4.4, 4.5 Nov 15, 2018

@aduth

aduth approved these changes Nov 15, 2018

This is definitely the corrected behavior for the current implementation.

The current implementation doesn't make much sense anymore though. I don't think it's possible to delete a block without it also being the selected block? Probably more relevant when we had the trash can adjacent the hovered block. In any case, this would at least "just work" if something like that were introduced, or a plugin adds another option to delete a block.

@youknowriad youknowriad merged commit afc83f2 into master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad modified the milestones: 4.5, 4.4 Nov 15, 2018

@youknowriad youknowriad deleted the fix/small-effect-error branch Nov 15, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment