New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for store existance in withSelect HOCs for media components #11903

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@gziolo
Member

gziolo commented Nov 15, 2018

Description

This is follow-up for work done by @imath in #4155. It addresses comments left by @youknowriad:

How has this been tested?

npm test

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added this to the 4.5 milestone Nov 15, 2018

@gziolo gziolo self-assigned this Nov 15, 2018

@gziolo gziolo requested a review from youknowriad Nov 15, 2018

@gziolo gziolo force-pushed the update/tweaks-media-upload-check branch from 3569a54 to 60f90f1 Nov 15, 2018

@youknowriad

LGTM 👍

@gziolo gziolo modified the milestones: 4.5, 4.4 Nov 15, 2018

@gziolo gziolo merged commit 5f44a42 into master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/tweaks-media-upload-check branch Nov 15, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment