New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post/page title: add word-break keep-all #11907

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
3 participants
@jasmussen
Contributor

jasmussen commented Nov 15, 2018

The aim of this PR is to fix #11786. Specifically, to improve how words are broken onto multiple lines.

I suspect this PR improves that, and it's based on advice in #11786 (comment).

screenshot 2018-11-15 at 12 17 25

Post/page title: add word-break keep-all
The aim of this PR is to fix #11786. Specifically, to improve how words are broken onto multiple lines.

I suspect this PR improves that, and it's based on advice in #11786 (comment).

@jasmussen jasmussen added this to the 4.5 milestone Nov 15, 2018

@jasmussen jasmussen self-assigned this Nov 15, 2018

@jasmussen jasmussen requested review from designsimply and WordPress/gutenberg-core Nov 15, 2018

@mtias mtias modified the milestones: 4.5, 4.4 Nov 15, 2018

@mtias

mtias approved these changes Nov 15, 2018

Seems fair to me.

@jasmussen jasmussen merged commit faa4d47 into master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the try/fix-11786 branch Nov 15, 2018

@MYIG

This comment has been minimized.

MYIG commented Nov 15, 2018

It will be fixed soon right? thank you~~~~

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Nov 15, 2018

@MYIG I have merged in a fix that will ship with version 4.4 of the Gutenberg plugin. I expect it will solve your issue, but please return if it doesn't.

@MYIG

This comment has been minimized.

MYIG commented Nov 15, 2018

okay~

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Post/page title: add word-break keep-all (WordPress#11907)
The aim of this PR is to fix WordPress#11786. Specifically, to improve how words are broken onto multiple lines.

I suspect this PR improves that, and it's based on advice in WordPress#11786 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment