RichText: Don't update live DOM on composition

[ellatrix]

Description

See #11813 and #11795. This is just an attempt at fixing the issue.

How has this been tested?

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[youknowriad]

Approving because it seems to fix the issue https://wordpress.slack.com/archives/C02QB2JS7/p1542286893546800

[torounit]

@iseulde Tested this branch.
It is no longer decided automatically.

But another problem.
Input Japanese in Paragraph Block, after input delete, all characters deleted.

[ellatrix]

@torounit Thanks, I'll investigate further!

[yoavf]

Tested this by installing Japanese on my mac and setting it up like described here. If not using qwerty, make sure to also change the Romanji layout option.

Test:

• In a post add a list block
• Switch to Hiranga in the typing menu
• start tying the characters nihonn
• You should see it converted to にほん

Before:

After:

[torounit]

@iseulde

One character should be deleted, but all characters are deleted.

[ellatrix]

@torounit Does the deletion problem also happen before in 4.2, or was it okay back then? @yoavf Do you see the same problem?

[youknowriad]

From the code change, I don't think the deletion bug is an issue with the current PR

[yoavf]

＞@yoavf Do you see the same problem?

Works fine for me:

I'm on a mac, using Hiragana. @torounit what are you using?

[torounit]

@iseulde
the deletion problem not happen in 4.2, 4.3 and master. Only This Branch.

@yoavf
I'm on a Mojave. using Hiragana.

This problem does not occur when space or alphabet is mixed.

[ellatrix]

@torounit It would be good to have the sequence of events, e.g. using the tool shared by @ocean90: https://input-inspector.now.sh/.

[torounit]

@iseulde

https://input-inspector.now.sh/profiles/eP9rFmPp3uTfF3ycQLGB

nice tool !!!

[torounit]

on Firefox, the deletion problem not happen.

[ellatrix]

@torounit To be sure, this is on Mojave and Chrome? Do you use the native IME or something else?

[torounit]

@iseulde　
Result of input 『わたしは』after type delete 4times.

Chrome: https://input-inspector.now.sh/profiles/JlVBqRhcZWtZxWvLeKFc
Firefox: https://input-inspector.now.sh/profiles/FyxPjxZJRDEeNKBN3D9g

This is on Mojave and Chrome 70. This problem occur native IME（Hiragana）and Other IME (ATOK).
I will try Google Japanese input (mozc).

[ellatrix]

@torounit Could you try with 166ebd8? Thanks for you patience! :)

[ellatrix]

If that doesn't work I'll try 2 more things. :)

[torounit]

@iseulde 166ebd8 dosen't work. All characters deleted.

[atachibana]

FYI.
Test on Windows 10 Japanese without 166ebd8.
The same error of clearing entire block by one hit of BackSpace key occurred on Windows with both Google IME and MS IME.
Edge was OK for both IMEs.

Environment
Windows 10 Pro Japanese
Google IME and/or MS-IME
Chrome 70.0.3538.77
Edge 42.17134.1.0

[ellatrix]

Thanks! @torounit @atachibana Could you test again with 9110d08? :)

[torounit]

@iseulde 9110d08 dosen't work. :(

[ellatrix]

@torounit Thanks! Let me try one more thing. :) Also, why is "Enter" pressed in Chrome but not in Firefox?

[torounit]

@iseulde
"Enter" pressed both browser. but It is not recorded on Firefox.

safari: https://input-inspector.now.sh/profiles/2DDzBa29IEDb7IxmszZ9

[ellatrix]

@torounit Last try: 4e060d1.

[torounit]

@iseulde it works. in Chrome 70 on Mojave. 👍
I will try other browser.

[ellatrix]

@torounit Oh, great!!

[youknowriad]

Awesome collaboration work on this PR 👏

[torounit]

@iseulde Thanks !
Works properly on Chome 70 / Firefox 63 / Safari 12 on Mojave.

[ellatrix]

Cool! Thanks for all the help!

[waviaei]

Finally catching up (got caught up with messed up local env on my home MBA...)

• Mojave 10.14.1
• ATOK IME (note: its a 3rd party IME software, not the one default with Mac)
• Chrome 70.0.3538.102
• Safari 12.0.1
• Firefox 63.0.1

4e060d1 - as @torounit mentioned, it seem to have fixed it!
I did 1) type some Japanese, 2) then delete few letters, 3) then typed some more.
With following blocks. IME functioned normal as expected.
This is with Chrome.

• paragraph
• list
• quote
• heading
• preformatted
• code (mixed typing of code and comment out with Japanese text)
• pullquote
• table
• verse
• media and text
• button

For your info, I did test with 9110d08 and it was like this (I had not done through testing on 4.2, so I cannot be sure if worked correctly before, except for paragraph, list and quote).

• paragraph => delete button deleted everything (as per @torounit reported)
• list => seems fixed
• quote => seems fixed
• verse => no issue with input, but unable to delete anything at all
• pull quote => seems ok
• preformatted text => no issue with input, but when you move on to a next block, placeholder text reappears underneath the typed text
• code => seems ok
• button => placeholder text did not disappear when you start typing. Only disappear after you confirm the Japanese character.
• Media and text => text part was same as paragraph.

I think through testing with different blocks might still be needed, but looks good!

Many many thanks @iseulde @torounit !

[ellatrix]

@waviaei Thanks for the additional testing. It seems the major issues have been fixed. Could you report any remaining issues separately? Thanks!

[mcsf]

Nice fix!