Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use the MediaUploadCheck component before each Upload component #11924
This PR should fix #11910
How has this been tested?
Using WordPress trunk & Gutenberg Master I've visually checked the bugs listed into the #11910 issue were fixed for the contributor role (user without the
Types of changes
Improves #4155 by making sure the forgotten Upload components are used after the MediaUploadCheck one.
It tests well. Great work on fixing all the remaining issues.
We discussed it on Slack, but I wanted to double check if you still think it is an option to include
@gziolo I've been looking into it and came to the conclusion that it's fine the way it is actually
So I thought, as we need to wrap the DropZone, FormFileUpload and the MediaUpload components into a MediaUploadCheck one anyway, doing an extra check into MediaUpload was weird.
Let's go with the current approach and see how it work. There are so many different use cases where the check for upload permissions is necessary that it's hard to find a perfect approach. We can always iterate on it. Thanks for fixing all remaining bugs I could find.