New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText: mark onSplit as unstable #11926

Merged
merged 2 commits into from Nov 15, 2018

Conversation

Projects
None yet
3 participants
@iseulde
Member

iseulde commented Nov 15, 2018

Description

onSplit is an being revised in #11005, but it's not sure when we can land this change. In the meantime it would be good to mark onSplit as unstable. It's a relatively small deprecation. I don't expect many non core blocks to use this prop. Even in core we only use it for 3 blocks.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@iseulde iseulde added this to the 4.4 milestone Nov 15, 2018

@iseulde iseulde requested a review from WordPress/gutenberg-core Nov 15, 2018

@youknowriad

I still see it in the native versions of heading and paragraph, not sure how to go about that. cc @gziolo @hypest

@iseulde

This comment has been minimized.

Member

iseulde commented Nov 15, 2018

@youknowriad That's probably fine, RichText is entirely different there as well, handling the onSplit prop.

@youknowriad

This comment has been minimized.

Contributor

youknowriad commented Nov 15, 2018

Ideally they should align because the goal is that plugin author using RichText will have a block working in both editors without code changes. It's probably not as urgent as 4.4 but something we should follow-up on.

@youknowriad

This comment has been minimized.

Contributor

youknowriad commented Nov 15, 2018

I'm merging this, let's make sure we follow-up with what's needed for mobile.

@youknowriad youknowriad merged commit 55d7d33 into master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the try/mark-on-split-unstable branch Nov 15, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

RichText: mark onSplit as unstable (WordPress#11926)
* RichText: mark onSplit as unstable

* Remove deprecation version
@hypest

This comment has been minimized.

Contributor

hypest commented Dec 13, 2018

Late to the party but, @daniloercoli , @diegoreymendez can you check if there are things we need to do or update for the gutenberg-mobile side? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment