New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme to fix the path example by removing wp-json from it. #11942

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@fabiankaegy
Contributor

fabiankaegy commented Nov 15, 2018

While testing the apiFetch component we realised that the path didn't need to include wp-json because that has already been added.

Description

Updated the path parameter to mirror working code.

How has this been tested?

The apiFetch was tested with the example from the readme and produced an error. I realised that wp-json was in the URL twice. Therefore I removed it in the documentation.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
Updated Readme to fix the path example by removing wp-json from it.
While testing the apiFetch component we realised that the path didn't need to include wp-json because that has already been added.
@Soean

Soean approved these changes Nov 15, 2018

Good catch, thanks for the fix.

@Soean Soean added this to the 4.5 milestone Nov 15, 2018

@Soean Soean merged commit 45ff37f into WordPress:master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Updated Readme to fix the path example by removing wp-json from it. (W…
…ordPress#11942)

While testing the apiFetch component we realised that the path didn't need to include wp-json because that has already been added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment