Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Components: Set type=button for TabPanel button elements. #11944
The default button type is "submit" which submits the enclosing form.
I don't think it ever makes sense that you'd want a button in a tab panel to submit the form,
How has this been tested?
I tried to write a unit test for this, but apparently an
Types of changes
@gziolo Thanks for the ping. I took this for a spin and added this to the separator to test:
It doesn't seem like we're using this component anywhere in Gutenberg itself. It really seems like it should come with some basic styles, and I'm essentially echoing @aduth here. This is because the
But maybe that shouldn't hold up this PR if it fixes an issue? Not sure, and not sure how I can review this from a design perspective as there doesn't seem to be a design.
To put it more simply, if the above was the design we intended for the TabPanel component, it would not be shippable. But this could be a separate task, to improve that, as mentioned.
Jan 30, 2019
1 check passed
I merged this PR as is given that it doesn't have any impact on Gutenberg itself as I confirmed that this component is never used in the codebase. The change itself fixes the issue it references but let's work on the styles related improvements in a separate issue. I opened #13587 to track it. Let's discuss further steps there as it needs some design involvement.