New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder: fix missing margin on block icons that are not dashicons #11947

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@mtias
Contributor

mtias commented Nov 15, 2018

The placeholder component is only adding margin for block icons that are dashicons.

Before:
image

After
image

@mtias mtias added this to the 4.5 milestone Nov 15, 2018

@gziolo gziolo requested a review from jasmussen Nov 16, 2018

@jasmussen

Nice. Ship it.

@mtias mtias merged commit 9591c90 into master Nov 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtias mtias deleted the fix/block-icon-in-placeholders branch Nov 16, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment