New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for the format API #11948

Merged
merged 9 commits into from Nov 21, 2018

Conversation

Projects
None yet
5 participants
@raquelmsmith
Contributor

raquelmsmith commented Nov 15, 2018

Description

Closes #11583.

Added e2e test for the format API. See #11583.

How has this been tested?

Fired up the local dev env, activated the test plugin to make sure everything worked properly. Ran the e2e test suite and everything passed.

Types of changes

Adds an e2e test for the format API. The test:

  1. Makes sure that the format toolbar exists on a paragraph block when the test plugin is active
  2. Makes sure that clicking the formatting button adds the proper markup to the HTML

Checklist:

  • [ x ] My code is tested.
  • [ x ] My code follows the WordPress code style.
  • [ x ] My code follows the accessibility standards.
  • [ x ] My code has proper inline documentation.

@danielbachhuber danielbachhuber requested a review from gziolo Nov 15, 2018

@danielbachhuber danielbachhuber added this to the 4.5 milestone Nov 15, 2018

@gziolo gziolo requested a review from iseulde Nov 16, 2018

gziolo added some commits Nov 16, 2018

@gziolo

Great work. Thanks for your contrbution. I fixed some whitespace issues which weren't caught by linter, removed one commented out line and added missing dependencies in the JS script's registration. I will double check with @iseulde if we have everything covered and merge it when all checks on Travis are green.

@raquelmsmith

This comment has been minimized.

Contributor

raquelmsmith commented Nov 16, 2018

Ah, thank you for catching those issues @gziolo!

@gziolo gziolo added the Priority Low label Nov 19, 2018

@catehstn

This comment has been minimized.

catehstn commented Nov 19, 2018

Moving this to the 4.6 milestone, no rush to get this in today.

@catehstn catehstn modified the milestones: 4.5, 4.6 Nov 19, 2018

@raquelmsmith

This comment has been minimized.

Contributor

raquelmsmith commented Nov 20, 2018

Hm, the test is failing. Let me merge current changes into the branch and see if I can figure it out.

@raquelmsmith

This comment has been minimized.

Contributor

raquelmsmith commented Nov 20, 2018

Ok, all ready for another review :)

@catehstn

This comment has been minimized.

catehstn commented Nov 21, 2018

Great, I'd love to get this in asap - really appreciate the contribution, improving our test coverage is super important 💕

@gziolo when you have a minute, I'd really appreciate you taking another pass.

@gziolo

gziolo approved these changes Nov 21, 2018

@gziolo

This comment has been minimized.

Member

gziolo commented Nov 21, 2018

Yes, thank you very much. It looks good now. Let's get it in 🎉

@gziolo gziolo merged commit 5d275d1 into WordPress:master Nov 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Add e2e tests for the format API (WordPress#11948)
* Add e2e tests for the format API

* Fixes some whitespace issues

* Update format-api.test.js

* Add missing dependencies to the script registration

* Add snapshot to test

* Check for custom button, remove extra lines

* Change modifier keys used

From WordPress#11855

@gziolo gziolo modified the milestones: 4.6, 4.7 Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment