New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove absolute positions in link popover e2e test #11968

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@johngodley
Contributor

johngodley commented Nov 16, 2018

Removes the absolute positions in the link popover e2e test (see #11753)

How has this been tested?

Automated test confirms the test passes.

To test that it still catches the problem:

Types of changes

Update to an existing test

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@johngodley johngodley requested a review from WordPress/gutenberg-core Nov 16, 2018

@youknowriad

Thanks for the updates 👍

@johngodley johngodley added this to the 4.5 milestone Nov 16, 2018

@johngodley johngodley merged commit 2b567e9 into master Nov 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@johngodley johngodley deleted the update/link-test-popover-test branch Nov 16, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment