New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with Sibling Inserter. #11969

Merged
merged 2 commits into from Nov 19, 2018

Conversation

@jasmussen
Contributor

jasmussen commented Nov 16, 2018

The sibling inserter is the plus you see when you hover between two blocks.

When you have no blocks selected, or use the unified toolbar mode. you can access the sibling inserter between any two blocks.

When you have a block selected, and have the block-affixed toolbars, only the sibling inserter below the selected block should be availabl
e. Though it should still be keyboard accessible.

This PR fixes that.

Before:

before

After:

after

Fix regression with Sibling Inserter.
The sibling inserter is the plus you see when you hover between two blocks.

When you have no blocks selected, or use the unified toolbar mode. you can access the sibling inserter between any two blocks.

When you have a block selected, and have the block-affixed toolbars, only the sibling inserter below the selected block should be availabl
e. Though it should still be keyboard accessible.

This PR fixes that.

@jasmussen jasmussen added this to the 4.5 milestone Nov 16, 2018

@jasmussen jasmussen self-assigned this Nov 16, 2018

@jasmussen jasmussen requested review from aduth and WordPress/gutenberg-core Nov 16, 2018

@jorgefilipecosta

Hi @jasmussen, this works correctly in most of the cases. The only case where the problem still exists is if spotlight mode is enabled.

image

I think the problem happens because in this mode is-selected class is not added.

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Nov 16, 2018

Great catch, thank you Jorge. Pushed a fix for spotlight mode.

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Nov 19, 2018

@nosolosw

This comment has been minimized.

Member

nosolosw commented Nov 19, 2018

Everything is fine in my testing. Only a small gotcha with the columns block, the inserter for the columns block (not individual columns, but the whole block) is slightly covered by the column block toolbar :

screenshot from 2018-11-19 10-56-56

@youknowriad

It feels like this inserter is not useful in spotlight mode but probably a separate PR

@jasmussen jasmussen merged commit 66b95af into master Nov 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the try/fix-sibling-inserter-regression branch Nov 19, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Fix regression with Sibling Inserter. (WordPress#11969)
* Fix regression with Sibling Inserter.

The sibling inserter is the plus you see when you hover between two blocks.

When you have no blocks selected, or use the unified toolbar mode. you can access the sibling inserter between any two blocks.

When you have a block selected, and have the block-affixed toolbars, only the sibling inserter below the selected block should be availabl
e. Though it should still be keyboard accessible.

This PR fixes that.

* Fix for focus mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment