Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
RichText: remove iOS scroll adjusting #11971
With our new smooth enter behaviour (#11287), we no longer have a focus delay when creating a new paragraph on enter. It seems that we can remove the iOS fixes that adjust the scroll position when a block receives focus and when enter/delete is pressed.
Removing the fix actually results in even nicer scrolling because it is handled natively.
How has this been tested?
Test scroll behaviour on iOS when pressing enter and backspace.
Types of changes
Wow. This is hardcore impressive refactorings you've been doing. I love the amount of red in this PR! And the experience seems great to me:
I think it's important we get a few more people testing this as a sanity check, remember it has to be a physical device, or the Xcode simulator. But first impression looks seriously promising.
One issue that is completely unrelated, but becomes apparent again when testing this: we probably should never invoke "isEditing" mode on mobile, and always show the toolbar and selection borders. Reason being that it's otherwise both difficult and unintuitive to figure out how to make text bold. We are a bit limited here in what we can do because we are not a native app, and we are at the mercy of Mobile Safari (see also this) — but it still seems a better experience. But again, that's unrelated to this PR.
REALLY nice work!