Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd 'innerBlocks' support for transforms #11979
Conversation
mtias
added
the
Block API
label
Nov 16, 2018
This comment has been minimized.
This comment has been minimized.
I consider this PR more or less done from a code standpoint, as it is really minor. However, I have not yet written (possible) e2e tests, as I have no idea how to do that. But I've updated the 'inner-blocks-templates' test plugin to add an appropriate block to test my two changes. |
jorgefilipecosta
reviewed
Nov 16, 2018
Nice changes @Luehrsen, thank you for your contribution |
This comment has been minimized.
This comment has been minimized.
@jorgefilipecosta Done. While reviewing that doc-page: Aren't the ES5 examples wrong in terms of curly-braces and 'content' in reality being 'attributes'? |
aduth
requested changes
Dec 13, 2018
API-wise, this looks like a reasonable change which aligns with the general pattern of a "name, attributes, innerBlocks" triple when the name is already known. Could you make the following changes?
|
This comment has been minimized.
This comment has been minimized.
@aduth I have updated the changelog as requested, but I am a total noob in terms of TDD, so any help with the unit test would be MUCH appreciated. |
aduth
reviewed
Jan 9, 2019
packages/blocks/CHANGELOG.md Outdated
packages/blocks/CHANGELOG.md Outdated
aduth
force-pushed the
luehrsenheinrich:add/innerBlocks-support-transforms
branch
2 times, most recently
from
db3bb5c
to
408e6a7
Jan 24, 2019
aduth
approved these changes
Jan 24, 2019
I rebased and force-pushed to resolve conflicts and add missing unit tests. Writing the test for the multi-blocks, it became apparent that it's super goofy to pass as arguments two arrays of the |
Luehrsen commentedNov 16, 2018
•
edited by youknowriad
Description
This PR aims to provide support for 'innerBlocks' in transform rules. The proposed syntax is like this.
How has this been tested?
This PR has been manually tested. E2E tests are possible and the needed plugin code exists, the test itself has not been written.
Types of changes
Checklist:
closes #13052