Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNMobile: Register default block #11988

Merged
merged 1 commit into from Nov 16, 2018
Merged

Conversation

etoledom
Copy link
Contributor

Now that the Gutenberg Mobile uses the web store, we can take advantages of it.

This PR registers the paragraph block as the default block to be used when the user removes all blocks from the document, to ensure that there is always at least one block to type on.

default_block_demo

  • It works when removing blocks, not yet for starting a new empty post.
  • With the focus issue solved it will feel more "natural", with the cursor already in the paragraph block.

To test:
Follow the instructions in the gutenberg-mobile side:
wordpress-mobile/gutenberg-mobile#249

Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works as advertised, clean job here!
LGTM :shipit:

@etoledom etoledom merged commit 1b6cf07 into master Nov 16, 2018
@etoledom etoledom deleted the rnmobile/add-default-block branch November 16, 2018 22:22
@catehstn catehstn added this to the 4.5 milestone Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants