New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed plugin URL should be translatable #12013

Merged
merged 3 commits into from Nov 17, 2018

Conversation

Projects
None yet
3 participants
@dixitadusara
Contributor

dixitadusara commented Nov 17, 2018

Description

I have submitted PR as per your suggestions. Let me know If any changes require.

Previously: #11992

Fixes #11983.

@dixitadusara dixitadusara referenced this pull request Nov 17, 2018

Closed

Classic Editor plugin url should be translatable #11992

4 of 4 tasks complete

@swissspidy swissspidy self-requested a review Nov 17, 2018

@swissspidy swissspidy added the i18n label Nov 17, 2018

@swissspidy

This comment has been minimized.

Member

swissspidy commented Nov 17, 2018

There was no need to create a new PR just to address the feedback, but thanks for incorporating it.

Show resolved Hide resolved gutenberg.php Outdated
@swissspidy

There's currently PHPCS error because of the translator comment.

Update gutenberg.php for translator comment
Co-Authored-By: dixitadusara <dixitadusara@gmail.com>

@swissspidy swissspidy merged commit d1d4786 into WordPress:master Nov 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@catehstn catehstn added this to the 4.5 milestone Nov 19, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment