New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar permalink panel a11y improvements #12030

Merged
merged 2 commits into from Nov 19, 2018

Conversation

Projects
None yet
3 participants
@afercia
Contributor

afercia commented Nov 18, 2018

Splitting this out from #11874

screenshot 2018-11-18 at 14 45 44

In the new permalink sidebar panel, the "Preview" and "Permalink Settings" links use target="_blank" but users are not informed the link is going to open in a new browser's tab. Gutenberg has a component for this: ExternalLink, which adds the standard visually hidden text (opens in a new tab) and also adds an icon.

This PR uses ExternalLink for these two links.

Also, the value core currently used for the bold font weight is 600. See #11687, #5848, and, more importantly, https://core.trac.wordpress.org/changeset/37740. Core doesn't use 800 or 500. The second commit in this PR changes the links font weight to a normal weight and keeps the post-name part of the link bold.

Screenshot after:

screenshot 2018-11-18 at 14 45 22

@aduth

aduth approved these changes Nov 19, 2018

👍

@afercia afercia merged commit 3a57743 into master Nov 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@afercia afercia deleted the update/sidebar-permalink-panel-improvements branch Nov 19, 2018

@jorgefilipecosta jorgefilipecosta added this to the 4.5 milestone Nov 19, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Sidebar permalink panel a11y improvements (WordPress#12030)
* Use ExternalLink for links with target=_blank.

* Adjust font-weight values accordingly to current CSS coding standards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment