New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small gap in style variation button #12090

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@jasmussen
Contributor

jasmussen commented Nov 20, 2018

This PR fixes #12066.

I believe the issue is caused by the border on the button being an inset shadow, which stacks below the background colors of the content inside the preview. By making it a border, this becomes a non issue.

Before:

screenshot 2018-11-20 at 09 54 45

After:

screenshot 2018-11-20 at 09 54 32

Fix small gap in style variation button
This PR fixes #12066.

I believe the issue is caused by the border on the button being an inset shadow, which stacks below the background colors of the content inside the preview. By making it a border, this becomes a non issue.

@jasmussen jasmussen added this to the 4.6 milestone Nov 20, 2018

@jasmussen jasmussen self-assigned this Nov 20, 2018

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Nov 20, 2018

@jorgefilipecosta

LGTM 👍 Fixed the problem in my tests and I did not notice any regression.

@jasmussen jasmussen merged commit 015e144 into master Nov 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/12066 branch Nov 20, 2018

@youknowriad youknowriad modified the milestones: 4.6, 4.5 Nov 20, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Fix small gap in style variation button (WordPress#12090)
This PR fixes WordPress#12066.

I believe the issue is caused by the border on the button being an inset shadow, which stacks below the background colors of the content inside the preview. By making it a border, this becomes a non issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment