New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE11 toolbar. #12098

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented Nov 20, 2018

This PR is a better replacement for #12096.

In IE11, in the toolbar markup, you can briefly see the appearance of a new HTML element called <jscomp_symbol_react.fragment16>. This is obviously not a real element, but it is rendered by IE11 as a real element, which means it breaks the flexing of the actual children of the toolbar.

This PR, props to @youknowriad, adds a change to the assets so the element doesn't appear in the first place.

Before:

screenshot 2018-11-20 at 11 37 57

After:

screenshot 2018-11-20 at 11 37 34

closes #11918

Fix IE11 toolbar.
This PR is a better replacement for #12096.

In IE11, in the toolbar markup, you can briefly see the appearance of a new HTML element called <jscomp_symbol_react.fragment16>. This is obviously not a real element, but it is rendered by IE11 as a real element, which means it breaks the flexing of the actual children of the toolbar.

This PR, props to @youknowriad, adds a change to the assets so the element doesn't appear in the first place.

@jasmussen jasmussen added this to the 4.6 milestone Nov 20, 2018

@jasmussen jasmussen self-assigned this Nov 20, 2018

@jasmussen jasmussen requested review from youknowriad and WordPress/gutenberg-core Nov 20, 2018

@youknowriad youknowriad modified the milestones: 4.6, 4.5 Nov 20, 2018

@youknowriad

This comment has been minimized.

Contributor

youknowriad commented Nov 20, 2018

Let's backport this to Core as part of the packages upgrade.

@youknowriad

LGTM 👍

@youknowriad youknowriad merged commit 58d9803 into master Nov 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/ie11-toolbar branch Nov 20, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Fix IE11 toolbar. (WordPress#12098)
This PR is a better replacement for WordPress#12096.

In IE11, in the toolbar markup, you can briefly see the appearance of a new HTML element called <jscomp_symbol_react.fragment16>. This is obviously not a real element, but it is rendered by IE11 as a real element, which means it breaks the flexing of the actual children of the toolbar.

This PR, props to @youknowriad, adds a change to the assets so the element doesn't appear in the first place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment